Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass `this` into the promise function #1127

merged 1 commit into from May 9, 2019


None yet
2 participants
Copy link

commented May 9, 2019

Two levels of callbacks = two fat arrows needed. I'll try to add a spec or two for this.

Fixes atom/atom#19293


This comment has been minimized.

Copy link

commented May 9, 2019

Thanks for the quick fix! ❤️

@rafeca rafeca merged commit 28d27b5 into master May 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@rafeca rafeca deleted the wl-fat-arrow branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.