color .setting-description alignment #1146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Requirements
Description of the Change
This PR aligns the `.color .setting-description margin-top: -0.5em; pulls the description to about the same distance in e.g. checkbox settings descriptions,
Ive illustrated the description to a gif for visualization of what this PR does.
Alternate Designs
Thought about actually aligning both checkbox and swatches to be middle aligned to settings titles as well as the color settings description fix in the PR Something like (can be tested by adding this to your Atom stylesheet.
However the nature of that design choice may stray outside the intended design so I decided against submitting that for this reason.
Here it is how that would look.
If that alternate design is preferred let me know.
Benefits
Accounts mainly for color settings description top alignment to label in design.
Possible Drawbacks
This proposal was tested with All built in Atom themes and across Windows, macOS, Linux.
Applicable Issues
@lee-dohm as requested on slack