Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove atom-space-pen-views #913
referenced this pull request
Feb 16, 2017
I'm getting the following error installing
Atom: 1.14.2 x64
Uncaught NotFoundError: Failed to execute 'replaceChild' on 'Node': The node to be replaced is not a child of this node.
Thanks for the report @ungb. I was unable to reproduce locally, but I analyzed the code and tried to find possible ways in which it could have thrown that exception. I discovered a potential code path that could be causing what you experienced and made an attempt at fixing it in d3dba5e.
Please, let me know if you are still able to reproduce. If yes, we could maybe
The issue is now fixed for me @as-cii after your latest change regarding the issue I was having installing packages.
After your change:
I'm not sure why I'm seeing undefined exactly, but it's not related to your change. The style changed though.
Looks good to me, but looks like there's a conflict. Will look at this again after the merge conflict is resolve.
One little issue I found is if you open the list view in packages/theme/install and click on the author name, before your change it open the author page, Now it just goes into the package. If you click on the author name there, it goes to the author page.
Got this now. I am on 75e8896 which is after the supposed fix but not latest commit.
I'll pull latest and try to reproduce it.