Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for tab stops at ends of snippets #289

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
3 participants
@Ingramz
Copy link
Contributor

commented Feb 11, 2019

Description of the Change

Adds tests from #261 for an issue that has been since fixed. I could not find any tests that explicitly test this, which this pull request attempts to remedy. These tests fail pre-1.3.0 release.

Applicable Issues

#261

Add regression tests for tab stops at ends of snippets
Adds tests from #261 for an issue that has been since fixed.
@Aerijo

Aerijo approved these changes Feb 13, 2019

jasonrudolph added some commits Apr 25, 2019

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@Ingramz: Thanks for beefing up our test coverage. ⚡️

I pushed up a few minor naming/organizational tweaks, and I'll merge this pull request shortly.

@jasonrudolph jasonrudolph self-assigned this Apr 25, 2019

@jasonrudolph jasonrudolph merged commit d0a0732 into atom:master Apr 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.