New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add js erb response instance variable and classes #102

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@joseramonc
Contributor

joseramonc commented Oct 5, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Changes .js.erb syntax from this:

screen shot 2018-10-05 at 12 09 39 pm

to this:

screen shot 2018-10-05 at 12 08 30 pm

Benefits

Match ruby syntax in ruby blocks

joseramonc and others added some commits Oct 5, 2018

@simurai

simurai approved these changes Nov 14, 2018 edited

I wonder if these styles should go into a syntax/rails.less file, considering the scopes get added by the language-ruby-on-rails package?

Maybe fine for now to keep them in syntax/javascript.less. Thanks @joseramonc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment