New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tree-Sitter JavaScript highlighting for JSX file #104

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@ryanolsonx
Contributor

ryanolsonx commented Nov 3, 2018

This should also apply to standard JavaScript files, but specifically,
JSX syntax highlighting has been struggling.

Description of the Change

As noted in #100, there's a lot of highlighting missing when Tree-Sitter is enabled for JavaScript. The focus of this PR is to address many of those changes and provide much needed color. It doesn't fix everything perfectly. In atom/language-javascript, there's an issue (atom/language-javascript#618) that covers adding highlighting back for language keywords (such as this and super).

Before

46153660-356c1400-c239-11e8-91ef-27a6720e3df4

After

screen shot 2018-11-02 at 8 43 24 pm

Alternate Designs

None.

Benefits

JavaScript highlighting is improved.

Possible Drawbacks

None.

Applicable Issues

#100

Ryan Olson
Fix Tree-Sitter JavaScript highlighting for JSX file
This should also apply to standard JavaScript files, but specifically, 
JSX syntax highlighting has been struggling.
@ryanolsonx

This comment has been minimized.

Contributor

ryanolsonx commented Nov 13, 2018

@simurai Any thoughts on this?

@simurai

This comment has been minimized.

Member

simurai commented Nov 14, 2018

As noted in #100, there's a lot of highlighting missing when Tree-Sitter is enabled for JavaScript.

I think there is still some work in progress getting the Tree-sitter syntax highlighting more in sync with Textmate's. But we can still merge this now since it looks already much better.

@ryanolsonx Thanks.. 🙇

@simurai simurai merged commit 502d3f3 into atom:master Nov 14, 2018

@simurai simurai referenced this pull request Nov 14, 2018

Merged

Update Solarized themes #18434

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment