Skip to content
This repository has been archived by the owner. It is now read-only.

Style imports as solarized orange #94

Merged
merged 2 commits into from May 25, 2018

Conversation

Projects
None yet
2 participants
@ryanolsonx
Copy link
Contributor

ryanolsonx commented May 24, 2018

Description of the Change

In looking at the Solarized Home Page, I noticed that imports are usually orange (or in Haskell's case, magenta). Given that ES6 and TypeScript use imports as well, I thought that it would be nice to have support for that in this atom theme.

Alternate Designs

None.

Benefits

Contrast between code and imports.

Possible Drawbacks

None.

Applicable Issues

None.

@simurai
Copy link
Member

simurai left a comment

I think it's a good idea to stay close to the original. Thanks for the PR. 🙇

@@ -86,7 +86,7 @@
color: @blue;
}
.syntax--definition.syntax--begin.syntax--curly,
.syntax--definition.syntax--end.syntax--curly, {
.syntax--definition.syntax--end.syntax--curly {

This comment has been minimized.

@simurai

simurai May 25, 2018

Member

👍 for this fix

@simurai simurai merged commit b7747c9 into atom:master May 25, 2018

@ryanolsonx

This comment has been minimized.

Copy link
Contributor Author

ryanolsonx commented May 25, 2018

No problem!

PS: I'll send a similar pull request for solarized-light-syntax sometime today.

@ryanolsonx ryanolsonx deleted the ryanolsonx:feature/import-coloring branch May 25, 2018

@ryanolsonx

This comment has been minimized.

Copy link
Contributor Author

ryanolsonx commented May 25, 2018

Just kidding, you beat me to it. 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.