New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color typescript types yellow #38

Merged
merged 2 commits into from May 28, 2018

Conversation

Projects
None yet
2 participants
@ryanolsonx
Contributor

ryanolsonx commented May 25, 2018

Description of the Change

Coloring TypeScript types as solarized yellow.

In looking at how solarized normally styles "types", I noticed that the type coloring for TypeScript in atom was inconsistent.

Here's atom latest:
solarized-light-ts-types-before

You can see that primitive types get the green color while other types (whether interface or class) get a blue color. These really ought to be yellow.

Changes made in this pull request:
solarized-light-ts-types-after

Alternate Designs

None.

Benefits

Consistent type coloring for TypeScript.

Possible Drawbacks

Some users might want primitive types and other types to be different.

Applicable Issues

None.

@simurai simurai merged commit fc910f3 into atom:master May 28, 2018

@ryanolsonx ryanolsonx deleted the ryanolsonx:feature/typescript-types branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment