New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bracket matcher #45

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@simurai
Member

simurai commented Nov 2, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This makes the cursor-line semi-transparent so that the bracket matcher underneath can be seen.

bracket-matcher

Alternate Designs

We might could play with z-index, but that seems a bit more dangerous.

Benefits

Bracket matcher is visible.

Possible Drawbacks

  • Cursor line has a bit different color now.
  • Transparency can have negative performance impact.

Applicable Issues

Fixes #44

Make cursor-line semi-transparent
So that the bracket matcher can be seen underneath
@Aerijo

This comment has been minimized.

Aerijo commented Nov 2, 2018

@simurai

Transparency can have negative performance impact.

Isn't that how one-dark does it though? It seems negligible (especially when the alternative is not being able to see the bracket match).

@simurai simurai referenced this pull request Nov 2, 2018

Merged

Fix bracket matcher #103

@simurai

This comment has been minimized.

Member

simurai commented Nov 2, 2018

It seems negligible

Yeah.. 👍 Using z-index could also be bad for performance or cause other issues.

@simurai simurai referenced this pull request Nov 2, 2018

Closed

Bracket highlighting is partially borken #44

1 of 1 task complete

@simurai simurai merged commit f9fb7dd into master Nov 2, 2018

@simurai simurai deleted the sm-bracket-matcher branch Nov 2, 2018

@simurai simurai referenced this pull request Nov 14, 2018

Merged

Update Solarized themes #18434

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment