New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spell check large files (for now) #183

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
2 participants
@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Dec 16, 2016

Soon we're going to rewrite this package to only check the spelling of the content on screen. Until then, we're just going to avoid spell-checking large files.

/cc @ungb @lee-dohm

Closes #170

@steelbrain - I'd prefer to perform the check for largeFileMode even earlier. There's no need to even create a SpellCheckView for large files.

@steelbrain

This comment has been minimized.

Copy link

steelbrain commented Dec 16, 2016

Thanks @maxbrunsfeld 👍

@maxbrunsfeld maxbrunsfeld merged commit 6670322 into master Dec 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-disable-for-large-files branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment