New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about SPELLCHECKER_PREFER_HUNSPELL to README.md #213

Merged
merged 1 commit into from Jan 20, 2018

Conversation

Projects
None yet
4 participants
@segevfiner
Contributor

segevfiner commented Jun 7, 2017

Description of the Change

Add note about SPELLCHECKER_PREFER_HUNSPELL to README.md

See spellchecker/src/spellchecker_win.cc:270-274. That's of course assuming this works since I didn't really verify that it does.

@rriemann

This comment has been minimized.

rriemann commented Jan 11, 2018

Any progress in this PR?

@segevfiner

This comment has been minimized.

Contributor

segevfiner commented Jan 14, 2018

Doesn't seem like it. But note that it's just a documentation update. The actual feature is already there.

@rsese

This comment has been minimized.

Member

rsese commented Jan 19, 2018

Mentioned this one to the team - @dmoonfire we were wondering if you could take a look when you have a moment?

@dmoonfire

This comment has been minimized.

Contributor

dmoonfire commented Jan 19, 2018

Will do.

@dmoonfire dmoonfire merged commit 510b8d1 into atom:master Jan 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@segevfiner segevfiner deleted the segevfiner:patch-1 branch Jan 20, 2018

@dmoonfire

This comment has been minimized.

Contributor

dmoonfire commented Jan 20, 2018

I verified this on a Windows 10 machine using French dictionaries from Huspell (since I only have English and German language packs installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment