New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't watch editors more than once if they're re-added to the workspace #222

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@as-cii
Member

as-cii commented Oct 20, 2017

This will prevent this package from providing its functionality to editors more than once in case they get added to the workspace, then removed from it and finally added back.

/cc: @nathansobo @jasonrudolph

@jasonrudolph

This comment has been minimized.

Show comment
Hide comment
@jasonrudolph

jasonrudolph Oct 20, 2017

Member

It looks like the Travis CI failure is unrelated to this PR, but I've opened #223 to get that fixed.

Member

jasonrudolph commented Oct 20, 2017

It looks like the Travis CI failure is unrelated to this PR, but I've opened #223 to get that fixed.

@as-cii as-cii merged commit a3ec6f7 into master Nov 28, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@as-cii as-cii deleted the as-dont-watch-same-editor branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment