Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix tests #240
Description of the Change
In an attempt to make tests more reliable, I have decaffeinated spell-checks-spec.coffee, so that I could use
@lee-dohm: I have rebuilt this branch three times and tests seem to be much more reliable (I haven't observed any failure).
@maxbrunsfeld: can I talk you into taking a look at the TODO above? It seems like tree-sitter parsers are enabled by default on master and they are breaking spell-check because it still relies on legacy scope names to decide which grammars and syntactic constructs to spell-check.
referenced this pull request
Mar 9, 2018
Mar 12, 2018
I think it was just a problem with the spell-check tests. They enabled spell-check for the
Interesting. The main reason why I pointed that out was that after looking at the following lines of code:
It seemed like the config settings could refer to the legacy scope names, which would not work when tree-sitter is on. What am I missing?