New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to have a relative path for dictionary lookup. #249

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@dmoonfire
Contributor

dmoonfire commented Apr 17, 2018

  • User can use pseudo-drives to create relative paths:
    • Implement atom-pathspec
    • Issue #203 would use application:../dictionaries for searching.
    • Addresses some issues referenced in #204.
    • See above link for how to use home-, download-, and configuration-relative paths.
  • Added no new tests because couldn't find a way of referencing relative paths in a test.

Requirements

  • All new code requires tests to ensure against regressions

Not sure how to write tests that use a relative path since that is outside of the test.

Description of the Change

Issue #203 is asking for the ability to have a relative path for dictionary search paths for portable installations. This introduces the concept of pseudo-drives for path specifications to allow Electron to use those as a root and enable paths relative to various different roots like the application, the user's home, configuration, or downloads folder.

Alternate Designs

There seemed to be too many "relative to what" questions involved so I wasn't sure of another way to implement this.

Benefits

This will allow portable installations to have custom dictionaries.

Possible Drawbacks

  • It adds yet another layer to the path resolution code.
  • There is no existing patterns for handling "relative to" path specifications.

Applicable Issues

  • #203: This would allow portable installations.
  • #204: A combination issue including #203.
Added the ability to have a relative path for dictionary lookup.
* User can use pseudo-drives to create relative paths:
  * Implement [atom-pathspec](https://www.npmjs.com/package/atom-pathspec)
  * Issue #203 would use `application:../dictionaries` for searching.
  * Addresses some issues referenced in #204.
  * See above link for how to use home-, download-, and configuration-relative paths.
* Added no new tests because couldn't find a way of referencing relative paths in a test.

@dmoonfire dmoonfire requested a review from maxbrunsfeld Apr 17, 2018

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented May 1, 2018

@nathansobo Can you merge and do the version dance for this?

@daviwil

This comment has been minimized.

Member

daviwil commented May 25, 2018

I'll get this merged and ship a new update

@daviwil daviwil merged commit 24a66d0 into atom:master May 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment