Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the misconfiguration notice a warning and added suggestions on h… #255

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@dmoonfire
Copy link
Contributor

dmoonfire commented May 4, 2018

Requirements

This is to address #253.

Description of the Change

  • Made the error a warning to indicate it was less serious
  • Added the package name in the warning to make it easier to configure.
  • Added OS-specific hints in the README on how to fix it.
  • Show the search paths on the console. Also change the message if system dictionaries are used.

Alternate Designs

  • None

Benefits

See #253.

Possible Drawbacks

Yellow is ugly on my theme.

# to load it works.
# to load it works. We also include OS-specific package instructions to
# help solve the problem.
packageInstructions = ""

This comment has been minimized.

@HotelCalifornia

HotelCalifornia May 5, 2018

any reason to not prepopulate this with "You may need to install the missing language "?

This comment has been minimized.

@dmoonfire

dmoonfire May 5, 2018

Author Contributor

As far as I know, packageInstructions will be set for the three platforms Atom runs on because of the if checks later. I just didn't know a good generic version for an operating system beyond Windows, Mac, and Linux. So, the blank will have it concat later on safely in the case, but the if statements would make any assignment on the initializer unused. I don't feel very strong either way, just felt sufficient to leave it blank.

@dmoonfire dmoonfire force-pushed the dmoonfire:less-serious-warnings branch from e874b2d to 70966e4 May 7, 2018

@dmoonfire dmoonfire referenced this pull request May 10, 2018

Open

spell-check throws an error at atom launch #253

5 of 6 tasks complete

@dmoonfire dmoonfire force-pushed the dmoonfire:less-serious-warnings branch 5 times, most recently from b3d50e4 to e0ec2ca Jun 26, 2018

Made the misconfiguration notice a warning and added suggestions on h…
…ow to fix it.

* `README.md`: Added details on how to install new dictionaries.
    * Instructions for Ubuntu, RedHat, and Windows 10.
* Simplified the warning message:
    * Moved the list of search paths into the console only.
    * Changed the notice to look at the settings page.
    * Added a link to the settings page from the dialog.
    * Indicated when system dictionaries were being used.

@dmoonfire dmoonfire force-pushed the dmoonfire:less-serious-warnings branch from e0ec2ca to 6608e22 Jul 11, 2018

@lee-dohm lee-dohm merged commit 31bf3d9 into atom:master Jul 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dmoonfire dmoonfire deleted the dmoonfire:less-serious-warnings branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.