Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor builds against Atom beta with Electron 2.0.1 #258

Merged
merged 2 commits into from May 25, 2018

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented May 25, 2018

spell-check is no longer building correctly against Atom Beta due to some conflict between Electron 2.0 and the build tools on AppVeyor.

@daviwil daviwil changed the title WIP: Fix AppVeyor builds against Atom beta with Electron 2.0.1 Fix AppVeyor builds against Atom beta with Electron 2.0.1 May 25, 2018

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented May 25, 2018

Looks like the version of Visual Studio (2013) was too old. Updating to 2015 fixed it!

@daviwil daviwil merged commit c78d05f into master May 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-fix-appveyor branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.