New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large file check #265

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@hansonw
Contributor

hansonw commented Aug 17, 2018

We've received internal reports that spell-check still doesn't seem to have great performance characteristics for very large files (not sure if there are plans to fix this :P)

Unfortunately, the check to disable spell-check on large files was using editor.largeFileMode, which is no longer a supported API (It's now part of TextMateLanguageMode, which we can't really count on).

https://github.com/atom/atom/search?q=largeFileMode&unscoped_q=largeFileMode

Instead, we'll just get the buffer's length and compare it to our own LARGE_FILE_SIZE (set to 2MB, the same as the one in TextMateLanguageMode.)

@hansonw hansonw requested a review from maxbrunsfeld Aug 17, 2018

@rsese rsese added the tree-sitter label Aug 20, 2018

@queerviolet queerviolet merged commit 84b9088 into master Aug 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the hw-large-files branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment