New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unregistered TextEditors #271

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@Arcanemagus
Contributor

Arcanemagus commented Sep 17, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

If the TextEditor was ignored by the observe callback on all TextEditors there was a good reason for that (currently large files). Respect that and handle when the TextEditor isn't currently in the list of spellCheckViews.

Alternate Designs

There is probably a more "CoffeeScripty" way of doing this check, but as this code should be converted to JavaScript anyway this isn't really relevant.

Benefits

No error is thrown to the user.

Possible Drawbacks

No feedback to the user that their command did nothing if they wanted to spell check a TextEditor that was ignored.

Applicable Issues

Fixes #210.

🐛 Ignore unregistered TextEditors
If the TextEditor was ignored by the observe callback on all TextEditors 
there was a good reason for that (currently large files). Respect that 
and handle when the TextEditor isn't currently in the list of 
spellCheckViews.

Fixes #210.
@Arcanemagus

This comment has been minimized.

Contributor

Arcanemagus commented Sep 17, 2018

Looks like the PR template in this repo is missing the prompt and I forgot to mention this, but I verified this fix by applying the changes here to the local files and running Atom in dev mode to use them.

@lee-dohm lee-dohm merged commit 3161349 into master Sep 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lee-dohm lee-dohm deleted the la-ignore-unregistered-texteditors branch Sep 25, 2018

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented Sep 25, 2018

Let us know if you need help with the version dance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment