New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When copying the relative path, paths should be relativized before UR… #213

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@hansonw
Contributor

hansonw commented Oct 19, 2017

For Nuclide's remote URLs, shift-click to relativize doesn't quite work correctly because the status bar calls atom.project.relativize after the URL has been stripped!

We used to be very lenient with our relativize functions, but now that we check that both URLs are remote this no longer works as intended.

The fix is simple: just call relativize before we do any fancy URL parsing.

Released under CC0.

@hansonw hansonw requested a review from damieng Oct 19, 2017

@hansonw

This comment has been minimized.

Show comment
Hide comment
@hansonw

hansonw Oct 19, 2017

Contributor

Note that this is consistent with @updatePathText, which directly relativizes the path without any processing.

Contributor

hansonw commented Oct 19, 2017

Note that this is consistent with @updatePathText, which directly relativizes the path without any processing.

@damieng damieng merged commit 786457e into master Oct 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@damieng damieng deleted the hw-remote-copy-relative branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment