New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not focus CursorPositionView after clicking on it #214

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 6, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Keep the focus on whatever element was focused before the cursor position tile is clicked.

Alternate Designs

None.

Benefits

This tile can no longer be focused and will instead transfer focus back to the original element. Which means that you can open the Go to Line modal panel, cancel it, and continue typing like nothing happened.

Possible Drawbacks

None.

Applicable Issues

Fixes #82

@50Wliu 50Wliu merged commit 420cd5d into master Nov 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-cursor-position-href branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment