New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of the icons #231

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
1 participant
@simurai
Copy link
Member

simurai commented Dec 7, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR adds some margin to icons. Also, fixes padding/margin when the tiles are buttons.

Before

before

After

after

Alternate Designs

N/A

Benefits

Wide icons don't touch the text.

Possible Drawbacks

It may breaks themes that already added a "gap" in a different way, for example by using padding.

Applicable Issues

Closes atom/github#1803

@simurai simurai merged commit 19977e1 into master Dec 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm/icon-margin branch Dec 7, 2018

@simurai simurai referenced this pull request Dec 10, 2018

Merged

:arrow_up: status-bar@v1.8.16 #18557

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment