New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize HTML as HTML without beautification #64

Merged
merged 2 commits into from Nov 5, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 5, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The first commit removes the js-beautify dependency. All our HTML can already be considered "beautified". I did a manual visual check and cannot find any differences between the raw and beautified HTML output. The second commit tokenizes HTML as HTML instead of...XML?

Alternate Designs

None.

Benefits

More accurate highlighting through Highlights, as well as one less dependency to install and require.

Possible Drawbacks

Perhaps js-beautify was doing something important.

Applicable Issues

None.

50Wliu added some commits Nov 5, 2017

🔥 js-beautify
We were trying to beautify HTML with it...

@50Wliu 50Wliu merged commit 3111cb6 into master Nov 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-html branch Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment