New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant caret in the regex in symbols-view.js #228

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@segevfiner
Contributor

segevfiner commented Sep 18, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Remove a double caret from a regex in symbols-view.js. To the best of my understanding, this just matches the start of the string twice, which is a no-op.

Benefits

Cleanup.

Possible Drawbacks

None, unless this double caret holds some secret meaning I don't know about. 馃槈

@Ben3eeE Ben3eeE requested a review from 50Wliu Sep 18, 2017

@50Wliu 50Wliu merged commit 18c3b68 into atom:master Sep 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 18, 2017

Member

None, unless this double caret holds some secret meaning I don't know about. 馃槈

Wouldn't surprise me if JavaScript did decide to assign a special meaning to it 馃檴

Member

50Wliu commented Sep 18, 2017

None, unless this double caret holds some secret meaning I don't know about. 馃槈

Wouldn't surprise me if JavaScript did decide to assign a special meaning to it 馃檴

@segevfiner segevfiner deleted the segevfiner:sf-double-caret-cleanup branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment