New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize tab width onDragLeave or when tab is opened in a new window #523

Merged
merged 10 commits into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@50Wliu
Member

50Wliu commented Sep 24, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Continuation of #380, with @Ben3eeE's comments addressed and the code updated.

Alternate Designs

I considered adding a global variable mouseActive to track if the mouse was in the tab bar or not, but it looks like mouseleave is buggy and does not fire a) when dragging or b) when right-clicking.

Benefits

"Smoother" animations.

Possible Drawbacks

This same exact code snippet now appears three times in the codebase.

Applicable Issues

Fixes #371
Supersedes and closes #380

@Ben3eeE for testing

@Ben3eeE

This comment has been minimized.

Show comment
Hide comment
@Ben3eeE

Ben3eeE Sep 25, 2017

Member

LGTM! :shipit:?

Member

Ben3eeE commented Sep 25, 2017

LGTM! :shipit:?

@50Wliu 50Wliu merged commit bca8c9d into master Sep 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-anderoonies-resize-width branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment