Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old function guards #549

Merged
merged 2 commits into from Dec 15, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Dec 14, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

These guards were put into place as new features were added to Atom but not yet available on stable. All the features are now in stable Atom, so the guards can be removed.

Alternate Designs

None.

Benefits

Less unnecessary conditionals.

Possible Drawbacks

tabs will stop working on Atom versions less than 1.17.

Applicable Issues

None, but helps a little with #548

50Wliu added some commits Dec 14, 2018

@50Wliu 50Wliu merged commit c75edc5 into master Dec 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-guards branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.