Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a split if the tab cannot be placed in the pane #550

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Dec 20, 2018

This fixes a regression from #548. The code there was toPane ? target, even though toPane was always undefined. I mistakenly moved the location check to after toPane's definition, even though we should always be able to look at target (as a split will not affect the pane's location).

50Wliu added some commits Dec 20, 2018

@50Wliu 50Wliu merged commit 5b9e8f9 into master Dec 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-fix-layout-regression branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.