Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix tab close on middle click for Electron 3 #552
Description of the Problem
When using Atom with Electron 3, a middle click does not close a tab. This happens, because Electron 3 is based on a Chrome version >= 55. Since then, Chrome changed how click events work. Non-primary clicks now fire the event
See https://developers.google.com/web/updates/2016/10/auxclick and https://developer.mozilla.org/en-US/docs/Web/Events/auxclick for more information on the event.
Description of the Change
This PR adds the
The change fixes the problem for Electron 3 while it does have no effect in Electron 2, since the
This helps with a future migration of Atom to Electron 3 and fixes the issue for unofficial distributions using Electron 3 now.