Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make tab scrolling settings work #553
Description of the Change
Where to even start? The tabScrolling setting uses a mixed enum of booleans and strings, and declares its type as any. This should be fine...except that since settings-view determines the value of a setting by looking at the HTML value, all booleans are coerced to strings. Then
Oh, and I also fixed being unable to disable tab scrolling after you enabled it without restarting the tabs package, as the event listener wasn't being removed (function equality). The event listener is now always active but only does anything if the tabScrolling setting is enabled.
Fix settings-view, because there's nothing technically wrong with how tabs decided to implement this setting.
Changing the tab scrolling setting through settings-view will work again, and tab scrolling can be disabled on the fly.