Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs correctly when dropped on another window #555

Merged
merged 3 commits into from Jan 19, 2019

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Jan 19, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The method signature for IPC callbacks is (event, args...), but the tabs package was using (args...) instead. This meant that when dropping a tab onto another Atom window, the original tab would never be destroyed as intended.

Alternate Designs

None.

Benefits

This fixes a long-standing bug with dropping tabs on other windows, which was not discovered by the tests as they called the callback manually.

Possible Drawbacks

The specs are a little hacky...since the listener callback is binded, it's almost impossible to spy on it correctly. So I resorted to spying on a function that the callback calls.

Applicable Issues

None.

50Wliu added some commits Jan 17, 2019

@50Wliu 50Wliu merged commit 53b686a into master Jan 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-drop-other-window branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.