Fix marker bugs #205

Merged
merged 4 commits into from Feb 11, 2017

Projects

None yet

1 participant

@maxbrunsfeld
Contributor
maxbrunsfeld commented Feb 10, 2017 edited
  1. The lazily created DisplayMarker that was emitted in the creation event would be immediately overwritten by a new DisplayMarker during creation.

  2. Calling DisplayMarkerLayer.findMarkers from a DisplayMarker.onDidDestroy callback threw an exception.

maxbrunsfeld added some commits Feb 10, 2017
@maxbrunsfeld @nathansobo maxbrunsfeld Avoid creating duplicate DisplayMarkers
when the DisplayMarkerLayer has onDidCreateMarker observers

Signed-off-by: Nathan Sobo <nathan@github.com>
18563ea
@maxbrunsfeld maxbrunsfeld 10.3.7-0
3674bc9
@maxbrunsfeld @nathansobo maxbrunsfeld Fix exception when findMarkers is called in an onDidDestroy callback
0a70dd0
@maxbrunsfeld maxbrunsfeld changed the title from Avoid creating duplicate DisplayMarkers to Fix marker bugs Feb 10, 2017
@maxbrunsfeld maxbrunsfeld 10.3.7-1
176951e
@maxbrunsfeld maxbrunsfeld merged commit f9d10bf into master Feb 11, 2017

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maxbrunsfeld maxbrunsfeld deleted the mb-ns-fix-display-marker-creation branch Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment