New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul package and remove atom-space-pen-views #23

Merged
merged 7 commits into from Feb 20, 2017

Conversation

Projects
None yet
2 participants
@as-cii
Member

as-cii commented Feb 17, 2017

This pull request is a substantial rewrite of almost the whole package. Every file that was previously using jQuery has now been converted to JavaScript and its dependency on atom-space-pen-views has been removed too.
Feature-wise nothing should have changed, but this is another step toward removing jQuery from Atom.

/cc: @ungb

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Feb 17, 2017

Looks good, I didn't see any thing that broke here.

ungb commented Feb 17, 2017

Looks good, I didn't see any thing that broke here.

@as-cii as-cii merged commit a048335 into master Feb 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the as-remove-jquery branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment