New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of subscriptions properly when deactivating #27

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 4, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Like previous PRs in other repos, this PR makes sure that all subscriptions are disposed when Timecop is deactivated. This ensures that the Command Palette stays uncluttered and that multiple Timecops are not created when repeatedly disabled and re-enabled.

Alternate Designs

None.

Benefits

Correct package deactivation.

Possible Drawbacks

None.

Applicable Issues

None.

@50Wliu 50Wliu merged commit 5aadd57 into master Nov 4, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-subscriptions branch Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment