New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #28

Merged
merged 3 commits into from Nov 4, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 4, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

  • Use atom.packages.hasActivatedInitialPackages() (and the relevant hook) to determine when to populate the Timecop view
    • Show Loading… before packages have finished activating
    • Prevents Timecop from improperly showing only a few packages activated due to the process.nextTick call
  • Remove optional Workspace methods in TimecopView that were just stubs

Alternate Designs

I noticed that there was also an atom.packages.hasLoadedInitialPackages. I'm going to experiment with that to see if we can use that to split up the view loading.

Benefits

Code savings and more accurate Timecop view

Possible Drawbacks

None.

Applicable Issues

None.

50Wliu added some commits Nov 4, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu
Member

50Wliu commented Nov 4, 2017

timecop-loading

@50Wliu 50Wliu merged commit 57b44ef into master Nov 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-cleanup branch Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment