New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show project load times when a project is deserialized #29

Merged
merged 3 commits into from Nov 4, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 4, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This prevents project and workspace load times from showing up as undefinedms. In addition, I have removed the window state load time as it was just the project load time and the workspace load time added together (and 0 when there was no project to load). Finally, the display order has been changed to better follow the logical load order:

  • Shell
  • Window
  • Project
  • Workspace

Alternate Designs

None.

Benefits

More logical display order and hiding of project + workspace times when there is no previous state.

Possible Drawbacks

None.

Applicable Issues

Fixes #24
Fixes #19

50Wliu added some commits Nov 4, 2017

Only show project load times when a project was deserialized
Also, reorganize display order:
* Shell
* Window
* Window state
* Project
* Workspace
🔥 Window state load time
This is just project load time + workspace load time, and is 0 when no
project is loaded.
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 4, 2017

Member

For reference, the only code that is executed that is captured by window state load time and not project/workspace load time is the following:

https://github.com/atom/atom/blob/761fa46863025bddf3df3ee63bec2780e6c1e14c/src/atom-environment.coffee#L1008-L1015

The time those lines take is extremely inconsequential.

Member

50Wliu commented Nov 4, 2017

For reference, the only code that is executed that is captured by window state load time and not project/workspace load time is the following:

https://github.com/atom/atom/blob/761fa46863025bddf3df3ee63bec2780e6c1e14c/src/atom-environment.coffee#L1008-L1015

The time those lines take is extremely inconsequential.

@50Wliu 50Wliu merged commit acfddff into master Nov 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-window-timings branch Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment