Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getFullExtension function #1059

Merged
merged 3 commits into from Jul 4, 2018

Conversation

Projects
None yet
3 participants
@bobintornado
Copy link
Contributor

bobintornado commented Apr 1, 2017

Make getFullExtension shorter, simpler, easier to read and reasoning.

@thomasjo

This comment has been minimized.

Copy link
Member

thomasjo commented Apr 4, 2017

Unless this helper function is indirectly covered by tree-view-spec.coffee#L1585, we're going to require some tests that ensure the original functionality remains unchanged after merging this PR.

/cc @atom/maintainers

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Apr 4, 2017

Yes, that's the indirect test (I was the one that wrote this helper). It shouldn't be too hard to write a test directly covering this behavior.

50Wliu added some commits Jul 4, 2018

@50Wliu 50Wliu changed the title :art: refactor getFullExtension function Refactor getFullExtension function Jul 4, 2018

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Jul 4, 2018

Will open a separate PR adding additional test coverage. Sorry for the delay @bobintornado!

@50Wliu 50Wliu merged commit c4a1f60 into atom:master Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.