New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability for `escape` to return focus to center #1127

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@jasonrudolph
Member

jasonrudolph commented Jun 9, 2017

Closes #1113.


Description of the Change

In Atom 1.16 and earlier, the tree view lived in a Panel. With the tree-view focused, hitting escape triggered this keybinding defined in atom/atom:

'.tool-panel.panel-left, .tool-panel.panel-right':
  'escape': 'tool-panel:unfocus'

In Atom 1.17, the tree view moved to a Dock. As a result, the keybinding above no longer works. With the tree-view focused, hitting escape currently triggers no keybindings at all.

This PR renames the existing tool-panel:unfocus command to tree-view:unfocus and it adds a keybinding to allow escape to trigger that command.

Alternate Designs

See #1113 (comment)

Benefits

Restores ability for escape to return focus to the workspace center

Possible Drawbacks

None that I can think of

Applicable Issues

#1113

@jasonrudolph jasonrudolph requested a review from maxbrunsfeld Jun 9, 2017

@maxbrunsfeld

maxbrunsfeld approved these changes Jun 9, 2017 edited

I think it makes sense to only apply this to the tree view for right now, as opposed to doing something that applies to docks in general.

@jasonrudolph jasonrudolph merged commit a31d1bd into master Jun 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the jr-escape-to-center branch Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment