Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add UI for moving conflicting entries #1180
Description of the Change
The decision whether to overwrite files when drag-n-dropping can now be done inside of Atom.
I'm not sure there are any.
I think this is ready for general review + testing, though I may continue polishing and adding tests during the next few days.
Quite disappointed how difficult it was to test this. It should become much easier once the files are converted to JS and async/await becomes available.
rafeca left a comment
I just left a small change suggestion to make sure that this works for symlinks, otherwise is good to go.
I really appreciate that you added some tests, and how you decided to handle the "Cancel" use case!