New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rename similarly-named files when moving a folder #1193

Merged
merged 2 commits into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@50Wliu
Member

50Wliu commented Oct 16, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This is the same fix as item#2 in #1182, but for rename/move operations. It adds two new events, will-move-entry and move-entry-failed, to keep track of whether or not a folder is being renamed and which editors to rename.

Alternate Designs

None - this is mostly a redo of #1182.

Benefits

Renames should no longer unexpectedly rename other files.

Possible Drawbacks

Some of the code was duplicated.

Applicable Issues

Fixes #1188

/cc @iolsen: as mentioned above, this is essentially the same as #1182, which you approved.

50Wliu added some commits Oct 16, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 18, 2017

Member

Ready for review.

Member

50Wliu commented Oct 18, 2017

Ready for review.

@50Wliu 50Wliu added the needs-review label Oct 18, 2017

@iolsen

This comment has been minimized.

Show comment
Hide comment
@iolsen

iolsen Oct 18, 2017

Contributor

@ungb can you give this a test pass on all 3 platforms? I'm 👍 if it works. 😄

Contributor

iolsen commented Oct 18, 2017

@ungb can you give this a test pass on all 3 platforms? I'm 👍 if it works. 😄

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Oct 18, 2017

Contributor

👀

Contributor

ungb commented Oct 18, 2017

👀

@ungb

This comment has been minimized.

Show comment
Hide comment
@ungb

ungb Oct 18, 2017

Contributor

Looks good on windows, mac and ubuntu! 🚢

/cc @iolsen @50Wliu

Contributor

ungb commented Oct 18, 2017

Looks good on windows, mac and ubuntu! 🚢

/cc @iolsen @50Wliu

@iolsen iolsen merged commit f2ce277 into master Oct 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iolsen iolsen deleted the wl-properly-rename branch Oct 19, 2017

@iolsen

This comment has been minimized.

Show comment
Hide comment
@iolsen

iolsen Oct 19, 2017

Contributor

Thanks, @50Wliu! 🥇

Contributor

iolsen commented Oct 19, 2017

Thanks, @50Wliu! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment