New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop `event-kit` from package dependenciess #1195

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
3 participants
@Alhadis
Contributor

Alhadis commented Nov 1, 2017

See the relevantdiscussion here Basically, using eval-time constructors has a negative performance:

atom/archive-view#47 (comment)

/cc @nathansobo

@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Nov 1, 2017

Contributor

❤️

Contributor

nathansobo commented Nov 1, 2017

❤️

@nathansobo nathansobo merged commit 9d38ef0 into atom:master Nov 1, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 1, 2017

Member

💯

Member

50Wliu commented Nov 1, 2017

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment