New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for element-icons service #1198

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@Alhadis
Contributor

Alhadis commented Nov 3, 2017

As requested by @nathansobo while reviewing #1146.

I'm sorry this took longer than it should have. I made the mistake of doing The Right Thing™ by collating icon-related specs into a single test-file, but forgot how flaky the current specs are. 😢 So I bailed on that and swore an oath to destroy both Jasmine and CoffeeScript in a hellish inferno. One day.

@Alhadis

This comment has been minimized.

Show comment
Hide comment
@Alhadis

Alhadis Nov 3, 2017

Contributor

(BTW, I don't use Vim. I added that modeline so I didn't have to change my config. There's a bug with some package where the indentation settings reset after saving, and I don't know why, so I have this. Should probably make a package for that or something. 😀

</irrelevance>

Contributor

Alhadis commented Nov 3, 2017

(BTW, I don't use Vim. I added that modeline so I didn't have to change my config. There's a bug with some package where the indentation settings reset after saving, and I don't know why, so I have this. Should probably make a package for that or something. 😀

</irrelevance>

@nathansobo nathansobo merged commit 7489c8a into atom:master Nov 3, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@nathansobo

This comment has been minimized.

Show comment
Hide comment
@nathansobo

nathansobo Nov 3, 2017

Contributor

It didn't feel like it took a long time to me FWIW. I've been super pleased with the entire interaction with you over merging in these features. Nice work and thank you.

Contributor

nathansobo commented Nov 3, 2017

It didn't feel like it took a long time to me FWIW. I've been super pleased with the entire interaction with you over merging in these features. Nice work and thank you.

@Alhadis Alhadis deleted the Cutlery-Drawer:service-specs branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment