This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add specs for element-icons service #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(BTW, I don't use Vim. I added that modeline so I didn't have to change my config. There's a bug with some package where the indentation settings reset after saving, and I don't know why, so I have this. Should probably make a package for that or something. 😀
|
|
✨ It didn't feel like it took a long time to me FWIW. I've been super pleased with the entire interaction with you over merging in these features. Nice work and thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @nathansobo while reviewing #1146.
I'm sorry this took longer than it should have. I made the mistake of doing The Right Thing™ by collating icon-related specs into a single test-file, but forgot how flaky the current specs are. 😢 So I bailed on that and swore an oath to destroy both Jasmine and CoffeeScript in a hellish inferno. One day.