New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open tree-view to auto-reveal files #1200

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@BinaryMuse
Member

BinaryMuse commented Nov 9, 2017

This PR changes tree-view such that the dock is not expanded automatically when files are revealed due to the Auto Reveal option being checked.

The matrix of behavior for various states of Auto Reveal and Focus On Reveal settings is now:

Auto Reveal / Focus On Reveal ➡️ off/off on/off off/on on/on
when changing pane items
tree-view opens if closed
active file is revealed
tree-view is focused
when running Reval Active File command
tree-view opens if closed
active file is revealed
tree-view is focused

In short:

  1. The tree-view will only be shown when running the Reveal Active File command
  2. The tree-view will only be focused when the Reval Active File command is run and Focus On Reveal is on

Fixes #796
Closes #983

@BinaryMuse

This comment has been minimized.

Member

BinaryMuse commented Nov 14, 2017

Tests on Windows are crashing due to #1203 which is resolved by bruce/node-temp#69 (and a dependency bump).

@BinaryMuse

This comment has been minimized.

Member

BinaryMuse commented Nov 14, 2017

These tests crash on Windows on master and pass on Travis, so I'm gonna go ahead and merge this.

@BinaryMuse BinaryMuse requested a review from kuychaco Nov 14, 2017

@kuychaco

👍 looks good

@BinaryMuse BinaryMuse merged commit ebe2614 into master Nov 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BinaryMuse BinaryMuse deleted the mkt-dont-open-tree-view-to-auto-reveal branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment