New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for treeViewOpenPromise to resolve before deactivating Tree View #1211

Merged
merged 2 commits into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Dec 7, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This ensures that the Tree View doesn't randomly pop up in a half-broken state after disabling the package.

Alternate Designs

None.

Benefits

An edge-case with deactivation will be fixed, and no longer will people wonder why a Tree View is still open even though they disabled the package.

Possible Drawbacks

Deactivation will occasionally take longer if the open promise takes a long time to resolve. Since this is async things shouldn't really matter.

Applicable Issues

Fixes #1136

50Wliu added some commits Dec 7, 2017

@50Wliu 50Wliu merged commit da6b692 into master Dec 8, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-deactivate-wait-for-open branch Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment