Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use @atom/temp instead of node-temp #1225
Potentially acceptable to get the AppVeyor tests running again, but we definitely need to fix the underlying issue because it's had user impact for a long time according to some really old bugs I saw. Looks like you're making progress on the
Thanks again for taking this on!
This PR contains a "quick-fix" to get Appveyor tests passing again. It does so by 1) switching over to
Downsides of this PR is that at least on Windows, automatic cleanup does not occur for the GUI-based spec runner, leaving many files in the temp directory. Realistically, this should not be a concern as temp directories are cleaned regularly in the first place, and because there is no preserved state on CI.
A more complete fix which addresses the root cause (node-pathwatcher aggressively locking directories and preventing them from being removed) is in progress at #1232.