New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Standard #1267

Merged
merged 6 commits into from Jul 4, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Jul 4, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Lint JavaScript files using StandardJS.

Alternate Designs

None.

Benefits

More consistent JS.

Possible Drawbacks

Had to add some very simple error handling for the File and Directory classes when fs.realpath returns an error. Not any worse off than it was before, though.

Applicable Issues

None.

@50Wliu 50Wliu merged commit 48b7cae into master Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-cleanup branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment