Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove realpathCache argument in fs.realpath #1269

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@50Wliu
Copy link
Member

50Wliu commented Jul 6, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Node 6 removed the cache argument from fs.realpath as it switched to a much faster native implementation. See nodejs/node#3594 for details. As Atom is now on Node 8, this argument is currently sitting there doing...nothing.

Alternate Designs

None.

Benefits

Removal of a confusing argument from a bygone era.

Possible Drawbacks

None.

Applicable Issues

None, though I caught this when working on #1232.

Remove realpathCache argument in fs.realpath
The cache was removed in Node 6 in favor of a faster native implementation. We're on Node 8 now.
@Arcanemagus

This comment has been minimized.

Copy link

Arcanemagus commented Jul 6, 2018

Would it be clearer to simply omit the options object?

@50Wliu

This comment has been minimized.

Copy link
Member Author

50Wliu commented Jul 6, 2018

Yes, it would 😀. Mind was on autopilot there.

@50Wliu 50Wliu merged commit 208d0bb into master Jul 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-rm-realpath-cache branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.