Collapse all directories even when nothing is selected

[edahlseng]

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions

Description of the Change

This pull request updates the collapseDirectory method so that when the allDirectories parameter is set to true, all directories will be closed, even if nothing is selected in the tree view. Previously, if nothing was selected in the tree view, this method would return before collapsing anything (even if allDirectories was set to true.

Alternate Designs

N/A

Benefits

Triggering collapse-all will always collapse all directories, even if an item isn't currently selected in the tree-view.

Possible Drawbacks

None that I'm aware of.

Applicable Issues

None that I'm aware of.

[50Wliu]

Looks good to me. Can you please write some tests to cover this updated behavior?

[edahlseng]

@50Wliu sure thing, happy to. How can I run the tests on my local machine? Looking through the CONTRIBUTING file and the package.json, I don't see a test command.

[50Wliu]

You can run them using atom --test spec in the tree-view directory or the window:run-package-specs command.

(Also, ignore the Appveyor failure. We have a few known flakes on it.)

[edahlseng]

@50Wliu, updated!

[50Wliu]

Thank you! 🌟

[edahlseng]

Thanks for merging @50Wliu! When is this expected to work into a release of Atom/what can I follow along with?

[50Wliu]

I'll be cutting a new release of tree-view today, which should make its way into Atom 1.34.0.