Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async atom.confirm #1295

merged 2 commits into from Jan 5, 2019


None yet
1 participant
Copy link

commented Jan 5, 2019


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

It looks like I missed these two calls during the initial async conversion. Use the callback version of atom.confirm to ensure that the message box does not block the renderer process.

Alternate Designs



Atom can continue functioning even when tree-view has a message box open.

Possible Drawbacks

The specs get a little uglier since we have to deal with callbacks now.

Applicable Issues


50Wliu added some commits Jan 4, 2019

@50Wliu 50Wliu merged commit da6fb8a into master Jan 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-async-confirm branch Jan 5, 2019

@50Wliu 50Wliu restored the wl-async-confirm branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.