Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async atom.confirm, take two #1297

Merged
merged 3 commits into from Jan 6, 2019

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

commented Jan 6, 2019

#1295, but with the flaky spec fixed.

You'll notice I fixed the two flaky specs by changing a click event to a direct selectEntry call. I think that is the safer way of doing things in general and will create a follow-up PR to do this across the board.

50Wliu added some commits Jan 6, 2019

@50Wliu 50Wliu merged commit 7a4b60c into master Jan 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the revert-1296-revert-1295-wl-async-confirm branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.