Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to cut/paste a file that already exists #1304

Merged
merged 3 commits into from Mar 17, 2019

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

commented Mar 17, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Emit an error when trying to cut/paste a file that already exists at the destination. Best viewed with whitespace changes off.

Alternate Designs

None.

Benefits

Consistency with drag-and-dropping and OS file managers.

Possible Drawbacks

An error when it used to silently fail.

Applicable Issues

Fixes #1303

50Wliu added some commits Mar 17, 2019

@50Wliu 50Wliu merged commit a589bca into master Mar 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-cut-eexist branch Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.