Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ temp@0.9.0 #1310

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

commented Apr 11, 2019

#1225 switched tree-view from using the official temp module to using a fork of the temp module (@atom/temp). We adopted the fork in order to get a newer version of rimraf: atom/node-temp@b5266da

Since the time we created the fork, the official temp module has upgraded to the same version of rimraf that we're using in our fork: bruce/node-temp@b5266da

With that in mind, I think we can switch back to using the official temp module, and we can decommission our fork.

/xref atom/atom#18991 (comment)

/fyi @50Wliu @daviwil


List of changes between @atom/temp@0.8.4 and temp@0.9.0: atom/node-temp@v0.8.4...upstream-v0.9.0

@50Wliu

50Wliu approved these changes Apr 11, 2019

@50Wliu

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

This was on my todo list, so I'm glad it's getting tackled now :).

@jasonrudolph jasonrudolph merged commit b63b896 into master Apr 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the temp-0.9.0 branch Apr 11, 2019

@jasonrudolph

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

With that in mind, I think we can switch back to using the official temp module, and we can decommission our fork.

Now that this pull request is merged, I've archived the @atom/temp fork.

@jasonrudolph jasonrudolph referenced this pull request Apr 11, 2019

Merged

⬆️temp@0.9.0 #19143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.